Upgrade to Junit5 (#1050)

* chore: Update to junit5 for servlet package

* chore: Update to junit5 for contrib package

* chore: Update to junit5 for common-image package

* chore: Update to junit5 for common-lang package

* chore: Update to junit5 for entire project files

* fix: test case for JPEGImageReaderTest failed for java 8 and 11

assertEquals was using old signature of junit4.

* Update common/common-io/src/test/java/com/twelvemonkeys/io/InputStreamAbstractTest.java

Co-authored-by: Harald Kuhr <harald.kuhr@gmail.com>

* Update common/common-io/src/test/java/com/twelvemonkeys/io/InputStreamAbstractTest.java

Co-authored-by: Harald Kuhr <harald.kuhr@gmail.com>

* Update imageio/imageio-bmp/src/test/java/com/twelvemonkeys/imageio/plugins/bmp/BMPImageReaderTest.java

Co-authored-by: Harald Kuhr <harald.kuhr@gmail.com>

* Update imageio/imageio-jpeg/src/test/java/com/twelvemonkeys/imageio/plugins/jpeg/JPEGImageReaderTest.java

Co-authored-by: Harald Kuhr <harald.kuhr@gmail.com>

* Update imageio/imageio-tiff/src/test/java/com/twelvemonkeys/imageio/plugins/tiff/TIFFImageMetadataTest.java

Co-authored-by: Harald Kuhr <harald.kuhr@gmail.com>

* Update imageio/imageio-tiff/src/test/java/com/twelvemonkeys/imageio/plugins/tiff/TIFFImageReaderTest.java

Co-authored-by: Harald Kuhr <harald.kuhr@gmail.com>

* Update imageio/imageio-tiff/src/test/java/com/twelvemonkeys/imageio/plugins/tiff/TIFFImageWriterTest.java

Co-authored-by: Harald Kuhr <harald.kuhr@gmail.com>

* Update imageio/imageio-core/src/test/java/com/twelvemonkeys/imageio/stream/BufferedChannelImageInputStreamTest.java

Co-authored-by: Harald Kuhr <harald.kuhr@gmail.com>

* Update imageio/imageio-core/src/test/java/com/twelvemonkeys/imageio/stream/BufferedChannelImageInputStreamTest.java

Co-authored-by: Harald Kuhr <harald.kuhr@gmail.com>

* refactor: few indentation changes and missed test case

- review change related to missing test annotation
- unwanted new lines inside test case
- duplicate assertions

* refactor: moved the lambda expression to method reference

* review: testNotNullWithParameterNull catch block was never executed.

Added the suggested change

* Apply suggestions from code review

chore: adjust suggested indentation

Co-authored-by: Harald Kuhr <harald.kuhr@gmail.com>

* Update imageio/imageio-core/src/test/java/com/twelvemonkeys/imageio/util/ImageReaderAbstractTest.java

Co-authored-by: Harald Kuhr <harald.kuhr@gmail.com>

* Update imageio/imageio-core/src/test/java/com/twelvemonkeys/imageio/util/ImageReaderAbstractTest.java

Co-authored-by: Harald Kuhr <harald.kuhr@gmail.com>

* Update imageio/imageio-core/src/test/java/com/twelvemonkeys/imageio/util/ImageWriterAbstractTest.java

Co-authored-by: Harald Kuhr <harald.kuhr@gmail.com>

* refactor: using assertTimeout doesnot kill the execution, even if the timeout happens.

It is better to use assertTimeoutPreemptively in cases, where we really want to kill the execution after timeout.
https://stackoverflow.com/questions/57116801/how-to-fail-a-test-after-a-timeout-is-exceeded-in-junit-5/57116959#57116959

---------

Co-authored-by: Harald Kuhr <harald.kuhr@gmail.com>

common/common-lang/src/test/java/com/twelvemonkeys/util/LinkedMapTest.java

@@ -45,15 +45,11 @@
 
 package com.twelvemonkeys.util;
 
-import org.junit.After;
-import org.junit.Before;
-import org.junit.Test;
-
 import java.util.Iterator;
 import java.util.Map;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertTrue;
+import org.junit.jupiter.api.*;
+import static org.junit.jupiter.api.Assertions.*;
 
 /**
  * Unit tests
@@ -74,7 +70,7 @@ public class LinkedMapTest extends MapAbstractTest {
      */
     protected LinkedMap labRat;
 
-    @Before
+    @BeforeEach
     public void setUp() throws Exception {
         // use makeMap and cast the result to a SeqHashMap
         // so that subclasses of SeqHashMap can share these tests
@@ -103,27 +99,21 @@ public class LinkedMapTest extends MapAbstractTest {
         }
 
         // Test size().
-        assertEquals("size() does not match expected size",
-                     expectedSize, labRat.size());
+        assertEquals(expectedSize, labRat.size(), "size() does not match expected size");
 
         // Test clone(), iterator(), and get(Object).
         LinkedMap clone = (LinkedMap) labRat.clone();
-        assertEquals("Size of clone does not match original",
-                     labRat.size(), clone.size());
+        assertEquals(labRat.size(), clone.size(), "Size of clone does not match original");
         Iterator origEntries = labRat.entrySet().iterator();
         Iterator copiedEntries = clone.entrySet().iterator();
         while (origEntries.hasNext()) {
             Map.Entry origEntry = (Map.Entry)origEntries.next();
             Map.Entry copiedEntry = (Map.Entry)copiedEntries.next();
-            assertEquals("Cloned key does not match original",
-                         origEntry.getKey(), copiedEntry.getKey());
-            assertEquals("Cloned value does not match original",
-                         origEntry.getValue(), copiedEntry.getValue());
-            assertEquals("Cloned entry does not match original",
-                         origEntry, copiedEntry);
+            assertEquals(origEntry.getKey(), copiedEntry.getKey(), "Cloned key does not match original");
+            assertEquals(origEntry.getValue(), copiedEntry.getValue(), "Cloned value does not match original");
+            assertEquals(origEntry, copiedEntry, "Cloned entry does not match original");
         }
-        assertTrue("iterator() returned different number of elements than keys()",
-               !copiedEntries.hasNext());
+        assertTrue(!copiedEntries.hasNext(), "iterator() returned different number of elements than keys()");
 
         // Test sequence()
         /*
@@ -207,7 +197,7 @@ public class LinkedMapTest extends MapAbstractTest {
     }
     */
 
-    @After
+    @AfterEach
     public void tearDown() throws Exception {
         labRat = null;
     }